Fix CI failures by running Ruby <= 2.2 on older Ubuntu image #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old versions of Ruby (<= 2.2) no longer work on the latest Ubuntu image. Fix by using `ubuntu-20.04` instead of `ubuntu-latest` for old Rubies. Also create a roll-up job called `test-all` that collects the results of `test` and `test-legacy` jobs into a single check that we can use for the branch protection rule.
mattbrictson
commented
Jul 1, 2023
| ruby: [ "2.0", "2.1", "2.2", "2.3", "2.4", "2.5", "2.6", "2.7", "3.0", "3.1", "3.2", "head" ] | ||
| ruby: ["2.3", "2.4", "2.5", "2.6", "2.7", "3.0", "3.1", "3.2", "head"] |
There was a problem hiding this comment.
🗒️ "2.0", "2.1", "2.2" have been moved to the new test-legacy job.
| @@ -19,6 +19,33 @@ jobs: | |||
| - name: Run tests | |||
| run: bundle exec rake test:units | |||
|
|
|||
| test-legacy: | |||
| runs-on: ubuntu-20.04 | |||
There was a problem hiding this comment.
🗒️ Use the older Ubuntu runner that is compatible with Ruby "2.0", "2.1", "2.2"
| - name: Run tests | ||
| run: bundle exec rake test:units | ||
|
|
||
| test-all: |
There was a problem hiding this comment.
🗒️ This aggregates all of the test* the matrix runs into a single check. That way the branch protection rule becomes much simpler.
| @@ -58,3 +99,15 @@ jobs: | |||
|
|
|||
| - name: Run functional tests | |||
| run: bundle exec rake test:functional | |||
|
|
|||
| functional-all: | |||
There was a problem hiding this comment.
🗒️ Likewise this aggregates all the functional* matrix runs into one check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old versions of Ruby (<= 2.2) no longer work on the latest Ubuntu image.
Fix by using
ubuntu-20.04instead ofubuntu-latestfor old Rubies.Also create roll-ups job called
test-allandfunctional-allthat collects the results of all the test and functional job runs for various Ruby versions into two checks that we can use for the branch protection rule.